Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Set log level of a specific package using logging trait #4844

Closed
wants to merge 32 commits into from
Closed

feat: Set log level of a specific package using logging trait #4844

wants to merge 32 commits into from

Conversation

realMartinez
Copy link
Contributor

@realMartinez realMartinez commented Oct 23, 2023 •
edited by squakez
Loading

  • added capability to the logging trait to set log level of user specified package
  • added unit test

Usage:
-t "logging.category.'org.test'=DEBUG"

Release Note

feat: Set log level of a specific package using logging trait

squakez
squakez reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to make generate in order to generate the trait documentation and CRD associated with the change. Thanks.

pkg/trait/logging_test.go Outdated Show resolved Hide resolved
@squakez squakez changed the title Feat: Set log level of a specific package using logging trait feat: Set log level of a specific package using logging trait Oct 23, 2023
@squakez squakez linked an issue Oct 23, 2023 that may be closed by this pull request
[RFE] Allow to set log level of a specific package using logging trait #3974
Open
squakez
squakez reviewed Oct 23, 2023
View reviewed changes
pkg/trait/logging_test.go Outdated Show resolved Hide resolved
@realMartinez
Copy link
Contributor Author

I generated the docs and also made the changes you requested.

squakez
squakez approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, good job! One more thing. We may provide an example inline with the new parameter as we do for route annotations.

@realMartinez
Copy link
Contributor Author

Great, good job! One more thing. We may provide an example inline with the new parameter as we do for route annotations.

I amended the documentation to include CLI usage example

@squakez squakez marked this pull request as draft October 25, 2023 09:09
@squakez
Copy link
Contributor

squakez commented Oct 25, 2023

@realMartinez I'm converting to a draft as I understand you're going to work on E2E test to validate the feature. Thanks.

github-actions bot and others added 14 commits November 13, 2023 09:09
@github-actions
chore: changelog automatic update
64e59a3
@github-actions
chore: nightly SBOM update
147ca6b
@dependabot
chore(deps): bump knative.dev/serving from 0.38.1 to 0.38.2
5d52be4 
Bumps [knative.dev/serving](https://github.com/knative/serving) from 0.38.1 to 0.38.2.
- [Release notes](https://github.com/knative/serving/releases)
- [Commits](knative/serving@v0.38.1...v0.38.2)

---
updated-dependencies:
- dependency-name: knative.dev/serving
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
fix: removed unnecessary defaul value
0aed1ee
@squakez
feat(api): Kamelet as static resource
33d1900 
Remove the reconciliation loop and the kamelet.status property
@squakez
chore(api): leave .status.phase=Ready as default
44a7264 
As it could be used by any external tool.
@dependabot
chore(deps): bump knative.dev/eventing from 0.38.4 to 0.38.5
c90765a 
Bumps [knative.dev/eventing](https://github.com/knative/eventing) from 0.38.4 to 0.38.5.
- [Release notes](https://github.com/knative/eventing/releases)
- [Commits](knative/eventing@v0.38.4...v0.38.5)

---
updated-dependencies:
- dependency-name: knative.dev/eventing
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@github-actions
chore: changelog automatic update
d5135db
@github-actions
chore: autogenerated project resource update
bcf1135
@github-actions
chore: nightly SBOM update
8fbac22
@dependabot
chore(deps): bump github.com/prometheus/common from 0.44.0 to 0.45.0
c23f801 
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.44.0 to 0.45.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.44.0...v0.45.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@github-actions
chore: changelog automatic update
49619fb
@github-actions
chore: nightly SBOM update
5196b75
@squakez
feat(build): add root image info
662708c 
* Useful to know from which image a kit hierarchy started
* added builder.base-image property trait to override easily the base image

Ref apache#2844
@github-actions GitHub Actions
Copy link
Contributor

🐫 Thank you for contributing! 🐫

Unable to create Coverage Report ⚠️.
Merge conflicts found.

@github-actions GitHub Actions
Copy link
Contributor

🐫 Thank you for contributing! 🐫

Unable to create Coverage Report ⚠️.
Merge conflicts found.

@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@realMartinez
Copy link
Contributor Author

Need to close this PR, will link this to the new one.

@realMartinez realMartinez mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squakez squakez squakez approved these changes

@gansheer gansheer gansheer approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
status/stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFE] Allow to set log level of a specific package using logging trait
5 participants
@realMartinez @squakez @oscerd @gansheer @valdar